chore: log timings for loading embedder model #129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds timing logs to help track the performance of loading the embedder model within the calculate_embeddings function.
- Initializes a timer before calling load_embedder and logs the elapsed time.
- Introduces an additional timer immediately before encoding, which isn’t currently used for logging.
Comments suppressed due to low confidence (1)
mostlyai/qa/_sampling.py:303
- The timer started at line 303 is not used for any logging or performance measurement. If it's intended to time the embedding calculation, consider adding a corresponding log statement.
t0 = time.time()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.